Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Try to fix travis #47

Merged
merged 7 commits into from Feb 22, 2018
Merged

Try to fix travis #47

merged 7 commits into from Feb 22, 2018

Conversation

laginha87
Copy link
Contributor

@laginha87 laginha87 commented Feb 19, 2018

  • Got the bin/ci file from the crystal lang repo and removed what wasn't needed.
  • Updated the Dockerfile to a more current version of crystal.
  • Started using the Dockerfile to build the image in travis.
  • Removed the Makefile cause it doesn't seem it is necessary.

Copy link
Contributor

@keplersj keplersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Nice job @laginha87

Copy link
Member

@faustinoaq faustinoaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Looks very nice 👍

@faustinoaq
Copy link
Member

faustinoaq commented Feb 21, 2018

@laginha87 Is this PR ready? Can I merge it?

Looks like @kofno is busy right now 😅

@laginha87
Copy link
Contributor Author

yes and yes.

@faustinoaq faustinoaq merged commit 1d8cb64 into master Feb 22, 2018
@faustinoaq faustinoaq deleted the laginha87/fix-travis branch February 22, 2018 15:10
@faustinoaq faustinoaq added this to Done in Crystal Tools Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Crystal Tools
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants