Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCache bust assets #16
Conversation
philnash
added some commits
Jan 5, 2017
This comment has been minimized.
This comment has been minimized.
Hmm... this failed because Rack 2.0.1 requires Ruby >= 2.2.2 and the build is being run with 2.2.0. I see that Travis is doing the build and then deploying (when on the master branch), I'll update the Ruby version to the latest in the 2.2.x series and try again. |
spalladino
requested a review
from
bcardiff
Jan 6, 2017
pushed a commit
that referenced
this pull request
Feb 3, 2017
This comment has been minimized.
This comment has been minimized.
vtiffenberg
closed this
Feb 6, 2017
This comment has been minimized.
This comment has been minimized.
Thanks @vtiffenberg! |
This comment has been minimized.
This comment has been minimized.
(I really should have taken at least 20 seconds to thank you, @philnash, instead of waiting to work on this. Anyways - thank you very much! |
This comment has been minimized.
This comment has been minimized.
No worries! Just glad to help out. Let me know if there's anywhere else I can pitch in. |
added a commit
that referenced
this pull request
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
philnash commentedJan 6, 2017
I noticed that @matiasgarciaisaia had referenced my blog post in #12 so I thought I'd take a crack at the task. This PR does a number of things to improve front end performance and avoid caching issues with CSS and JS.
@import
in the CSSEnsure that when you build the site,
JEKYLL_ENV
is set toproduction
otherwise there will be no minifying and no digest.