-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
bf5d462
commit 3c3d3e2
Showing
1 changed file
with
28 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4515, #4542, #4558, #4560, #4562, #4566, #4574, #4567, #4512, #4502, #4501, #4491, #3168, #4429, #4415, #4386, #4333, #4280, #4260, #4026, #3783, #4474 and #4216 could find a way to the changelog too...
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasgarciaisaia @asterite FYI, performing
apt-get update
ATM results in following error:3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sija - double thanks for this comments!
We're probably iterating the changelog a bit more tomorrow, but I'm surely going to work out the GPG issue. We did quite a few changes in the release process, and, while I actually tested installing Crystal on a fresh Ubuntu VM, I had already wiped every VM that had the package installed so couldn't test the upgrade.
So, long story short: thanks for the heads up, keep tuned for news 👌
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasgarciaisaia anyway Homebrew formula points to old release yet.
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akzhan yeah - that's (quite literally) another issue: Homebrew/homebrew-core#15035
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be worth mentioning somewhere that on ubuntu you need to run
again to update to this release.
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It installed on Ubuntu 14.04 (trusty) but there is a
libstdc++6
version mismatch, despite having v4.8.4 installed:I don't know which system the binary was built on (debian 8?) but it's not portable anymore to Ubuntu LTS releases (despite trusty having no issue with LLVM 3.8+ and
libstdc++
versions). Obviously the tarball has the same issue.3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ysbaddaden I've the same issue. So I decided to build from source.
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it goes any further, this discussion should better be in an issue. Nobody is gonna discover this on a commit.
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please open an issue and we'll schedule for 0.23.1... this is critical
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My Travis builds are now breaking and I think this might be the reason why. I can open a separate issue if anyone wants.
Then a little later
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just created #4648 to track the GPG issues with the Debian repo. If you can add any available data there (tried to find @Fryguy's travis build, but couldn't), that'll probably help us.
Thanks for bearing with us - loving this community! 💙
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're tracking @ysbaddaden's issue in #4647, just in case you arrive here with that very same issue.
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasgarciaisaia that's a looooong tomorrow you're havin' ;)
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you have no bad intentions, but he's been working non-stop throughout the week to solve the last issues with packages, so in a way it's been a long day for him indeed. @matiasgarciaisaia thanks for your hard work ❤️
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second that! Sorry if that come out sarcastic, my only intention was to file a friendly reminder before 0.23.1 will be released :) @matiasgarciaisaia thanks and keep up the good work! 👍
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3c3d3e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, all changelogs will be PRs (all commits to master will be PRs actually) so that this won't happen again.