Fix body locations for def nodes that have default args

[oprypin]

Currently it is reported that the actual body of the method begins at the first "assignment" to a default arg, if there is one:

          \/here
def foo(x, y=5)
  test
 /\not here
end

I think that's a bit arbitrary and won't be helpful for whatever tooling may rely on this, so I change it to be shown at the point of the "not here" example on the diagram.

This also fixes the body location for def self.new generated from def initialize.

[oprypin]

Specs that I'm adding were previously failing:

Failures:

  1) Normalize: def gives correct body location with default arg, without body
     Failure/Error: actual.body.location.should eq Location.new("", line_number: 2, column_number: 1)

       Expected: :2:1
            got: nil

     # spec/compiler/normalize/def_spec.cr:248

  2) Normalize: def gives correct body location with default arg with restriction, without body
     Failure/Error: actual.body.location.should eq Location.new("", line_number: 2, column_number: 1)

       Expected: :2:1
            got: nil

     # spec/compiler/normalize/def_spec.cr:248

  3) Normalize: def gives correct body location with splat arg, with body
     Failure/Error: actual.body.location.should eq Location.new("", line_number: 2, column_number: 1)

       Expected: :2:1
            got: :1:14

     # spec/compiler/normalize/def_spec.cr:248

  4) Normalize: def gives correct body location with splat arg, without body
     Failure/Error: actual.body.location.should eq Location.new("", line_number: 2, column_number: 1)

       Expected: :2:1
            got: :1:14

     # spec/compiler/normalize/def_spec.cr:248

  5) Normalize: def gives correct body location with block instance var arg, with body
     Failure/Error: actual.body.location.should eq Location.new("", line_number: 2, column_number: 1)

       Expected: :2:1
            got: :1:14

     # spec/compiler/normalize/def_spec.cr:248

  6) Normalize: def gives correct body location with block instance var arg, without body
     Failure/Error: actual.body.location.should eq Location.new("", line_number: 2, column_number: 1)

       Expected: :2:1
            got: :1:14

     # spec/compiler/normalize/def_spec.cr:248

[asterite]

Great!

[straight-shoota]

As a general consideration, I don't like specs in iterations because they seem unnecessarily hard to understand. Especially with nested iterations.
My preferred style would be a spec helper called with explicit source code of each combination. That also offers much flexibility and it would be easy to add specs for multi-line parameter lists for example.
I'm happy to accept this as is though.

[oprypin]

I don't mind, but in this particular case I don't see a good way to write this with a helper, particularly due to the nested iterations.
I think I will not do this change.

[straight-shoota]

This would be my proposal: straight-shoota@5da5886

[oprypin]

Hmm some things there that make me like that one less:

• The with body context comes in the wrong order (precedence).
• No possibility of auto-indenting the different cases.
• It is indeed a lot more code, and it's not like the helper will be reused for different tests.

For now I tweaked my version, maybe it looks a little better

[oprypin]

Diff between the two is still available