Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Reason enum for exhaustive case in nil-reason check #11449

Merged
merged 2 commits into from Nov 16, 2021
Merged

Create Reason enum for exhaustive case in nil-reason check #11449

merged 2 commits into from Nov 16, 2021

Conversation

rymiel
Copy link
Contributor

@rymiel rymiel commented Nov 13, 2021 •
edited

Resolves a TODO comment left in exception.cr. Note: may be overly verbose

@oprypin oprypin self-requested a review November 13, 2021 23:52
asterite
asterite approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@straight-shoota straight-shoota added this to the 1.3.0 milestone Nov 14, 2021
@straight-shoota straight-shoota merged commit 70a4f43 into crystal-lang:master Nov 16, 2021
@rymiel rymiel deleted the nil-reason-enum branch November 16, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@oprypin oprypin oprypin approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:compiler
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rymiel @asterite @oprypin @straight-shoota @HertzDevil