Skip to content

Add missing PartialOrder#<=>#2898

Merged
asterite merged 1 commit intocrystal-lang:masterfrom
makenowjust:fix/partial_order-ufo
Sep 18, 2017
Merged

Add missing PartialOrder#<=>#2898
asterite merged 1 commit intocrystal-lang:masterfrom
makenowjust:fix/partial_order-ufo

Conversation

@makenowjust
Copy link
Contributor

I think it's a bug.

@makenowjust
Copy link
Contributor Author

In fact, Comparable has <=> method, however PartialComparable doesn't have.

@straight-shoota
Copy link
Member

LGTM. Is there anything opposing this?

@akzhan
Copy link
Contributor

akzhan commented Sep 17, 2017

LGTM (just read docs of PartialComparable: Including types must provide an <=> method).

/cc @mverzilli

@asterite asterite merged commit 5c51ed1 into crystal-lang:master Sep 18, 2017
@mverzilli mverzilli added this to the Next milestone Sep 18, 2017
@RX14 RX14 added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants