Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing PartialOrder#<=> #2898

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Add missing PartialOrder#<=> #2898

merged 1 commit into from
Sep 18, 2017

Conversation

makenowjust
Copy link
Contributor

I think it's a bug.

@makenowjust
Copy link
Contributor Author

In fact, Comparable has <=> method, however PartialComparable doesn't have.

@straight-shoota
Copy link
Member

LGTM. Is there anything opposing this?

@akzhan
Copy link
Contributor

akzhan commented Sep 17, 2017 •
edited
Loading

LGTM (just read docs of PartialComparable: Including types must provide an <=> method).

/cc @mverzilli

@asterite asterite merged commit 5c51ed1 into crystal-lang:master Sep 18, 2017
@mverzilli mverzilli added this to the Next milestone Sep 18, 2017
@RX14 RX14 added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mverzilli mverzilli mverzilli approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
7 participants
@makenowjust @straight-shoota @akzhan @asterite @mverzilli @jhass @RX14