Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct IO#read_fully example #3601

Closed

Conversation

makenowjust
Copy link
Contributor

No description provided.

@RX14
Copy link
Contributor

RX14 commented Nov 28, 2016

Doc alterations shouldn't be ci skip because the formatter would fail after this change. Ci skip is almost useless commit message noise at best and harmful at worst.

@makenowjust
Copy link
Contributor Author

@RX14 ok

@makenowjust
Copy link
Contributor Author

makenowjust commented Nov 28, 2016

@asterite @waj if you have free time (indeed), could you tell me how you think above @RX14's opinion?

@asterite
Copy link
Member

@makenowjust I agree with @RX14, in this case the comments inside the comments should be aligned. If you run the formatter it will fix this. So [ci skip] shouldn't be used.

@makenowjust
Copy link
Contributor Author

makenowjust commented Nov 28, 2016

@asterite Thanks! for explain I will remove [ci skip] on next commit and fix this.

@makenowjust makenowjust force-pushed the fix/io-read-fully-example branch from c035058 to 71fed71 Compare November 28, 2016 13:14
@makenowjust makenowjust closed this Dec 1, 2016
@makenowjust makenowjust deleted the fix/io-read-fully-example branch December 1, 2016 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants