-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance --stats option #3643
Enhance --stats option #3643
Conversation
Wow. unknown ci failure again! |
Looks like the specs hang on travis once in a while. Probably a good idea to enable outputting of full spec names to work out if it's a specific spec each time. |
@RX14 I thought of doing the same. LET'S DO IT! 😸 |
d20f420 :-) @makenowjust Do you want to rebase against master? That way the specs will run in verbose mode and we could see if they stall in a specific one. |
dd9357a
to
73f2e22
Compare
@asterite Rebased! |
I think I'll just mark the condition variable specs as pending for now, as they aren't used anywhere in the code. We can wait until we need them (if we'll need them) when adding support for parallelism. And in any case those specs weren't written by us so they might be buggy (for example, this pcond.signal has no matching |
@makenowjust Thank you for this! This is super nice! I always wanted to compile + run + see execution time in one go but couldn't, so I end up compiling a binary and running it. Maybe, just for In any case I'll merge this because it's very useful :-) |
@asterite Yes. |
This pull request adds a statistic of the last process of some
crystal
sub-command (i.e. built binary execution time forcrystal run
, calculation time forcrystal tool implementation
, etc...)It is useful to distinguish real execution time from parsing time, processing AST time and generation binary time in one shot.