Tiny refactor of method_missing definition #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs 8295d8c |
asterite
reviewed
Dec 12, 2016
| @@ -38,7 +38,7 @@ module Crystal | |||
| def define_method_from_method_missing(method_missing, signature, original_call) | |||
| name_node = StringLiteral.new(signature.name) | |||
| args_nodes = [] of ASTNode | |||
| named_args_nodes = nil | |||
| named_args_nodes = [] of NamedArgument | |||
There was a problem hiding this comment.
But this will allocate an array all the time, even if not used...
There was a problem hiding this comment.
@asterite Oh, that's true. I wanted to stay "symmetrical" with args_nodes.
I wonder, is allocating an array a hotspot here?
Anyway, I could revert the change for named_args_nodes. How about the other changes? Should I close this PR?
There was a problem hiding this comment.
I usually don't care about hotspots, if I can easily avoid an allocation, I do it.
The other changes look good, though :-)
There was a problem hiding this comment.
@asterite I've reverted to named_args_nodes = nil. The other changes remained.
👀 ?
* Removed unused var `args_node` * Drop `try` for non-nil `named_args`
|
Thanks for merging! 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
args_nodeHandlenamed_args_nodessimilar toargs_nodestryfor non-nilnamed_args