Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Makefile to hack crystal #3685

Merged
merged 1 commit into from
Dec 13, 2016

Conversation

makenowjust
Copy link
Contributor

This pull request has three improvements. I know one pull request has only one improvement, however too small pull request causes confusing sometimes. I think a sometime is just now. (Of course if you want to separate this pull request, I welcome to do!)

  • Use spaces instead of tab as an indent of no command line
  • Add target description to all target
  • Add "optional variables" and "recipes" section for help outputs
  • Make llvm-config information colored (this is same color of ./bin/crystal's "Using compiled compiler at" information)

Finally, make help outputs are here:

make help outputs

- Use spaces instead of tab as an indent of no command line
- Add "optional variables" and "recipes" section for help outputs
- Output colored llvm-config information (this is same color of
  ./bin/crystal's "Using compiled compiler at" information)
@asterite
Copy link
Member

Looks really nice, thank you! 💜

@asterite asterite merged commit 2d86bd1 into crystal-lang:master Dec 13, 2016
@makenowjust makenowjust deleted the fix/makefile branch December 13, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants