Make HTTP::Handler a module #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before we hit 1.0 we usually don't care about introducing breaking changes. I'd directly make |
andrewhamon
force-pushed
the
handleable-module
branch
from
e2071a9 to
6bc72fb
Compare
andrewhamon
changed the title
|
@asterite made the changes! |
RX14
reviewed
Dec 15, 2016
| @@ -371,7 +375,8 @@ module Crystal::Playground | |||
| end | |||
| end | |||
|
|
|||
| class EnvironmentHandler < HTTP::Handler | |||
| class EnvironmentHandler | |||
| include HTTP::Handler | |||
There was a problem hiding this comment.
I would leave a blank line after here
andrewhamon
force-pushed
the
handleable-module
branch
from
6bc72fb to
4ec39e3
Compare
Because HTTP::Handler was just an interface, it is less restrictive on applications to be an includeable module rather than in inheritable class.
andrewhamon
force-pushed
the
handleable-module
branch
from
4ec39e3 to
42e88e5
Compare
|
If someone wants to cancel all those now useless Travis CI jobs that are queued, that would be nice :p I didn't mean to clog the tubes 😅 |
|
Even though this is a breaking change, the fix is easy (include instead of inherit). Let's do this! @andrewhamon Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because HTTP::Handler was just an interface, it is less restrictive on applications to be an includeable module rather than in inheritable class.
This is a proof of concept of what I mentioned in #3690