Add File and Dir empty? methods #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandrop
commented
Dec 18, 2016
| begin | ||
| stat(path).size == 0 | ||
| rescue Errno | ||
| raise Errno.new("Error determining size of '#{path}'") |
There was a problem hiding this comment.
This captures and re-raises the error, with a different message. I don't know if there's a more elegant / obvious way to do this.
asterite
reviewed
Dec 20, 2016
| raise Errno.new("Error determining size of '#{path}'") unless exists?(path) | ||
|
|
||
| foreach(path) do |f| | ||
| return false unless %(. ..).includes?(f) |
There was a problem hiding this comment.
I'm not sure this check is correct. %(. ..) is the string ". ..". Maybe it's safer to do {".", ".."}.includes?(f)?
There was a problem hiding this comment.
😱 You're right -- originally I meant to do %w, but the tuple way is better. Updating.
I think it worked just by happenstance of the way the String#includes? works.
|
@dylandrop I believe this is the correct way to implement these methods, the semantic you mention is pretty good :-) I just made a tiny comment, after that I'll merge this. |
dylandrop
force-pushed
the
add-file-and-dir-exists-methods
branch
from
9219d88
to
a7683aa
Compare
|
@asterite Done. |
|
@dylandrop Thank you for this! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
empty?to theFileandDirclasses. Closes #2951.This follows the proposed behavior of this comment. This varies from Ruby in that an error is raised if the file / dir is not found.
In terms of implementation -- the File version is pretty much identical to Ruby's. Interestingly, their implementation for Dir seems to have an optimization that leverages getattrlist. I didn't know if this was super valuable, but it's an optimization that could be added in a later PR.