Fix: IPAddress#address returns a nilable #3872
Conversation
| @@ -132,10 +132,6 @@ class Socket | |||
| end | |||
| end | |||
|
|
|||
| private def address(addr) : Nil | |||
| # shouldn't happen | |||
| end | |||
There was a problem hiding this comment.
How about keeping this method, and have it raise a @addr is not set exception, and remove the two not_nil! assertions above? I'm guessing it would be more descriptive should we land in that case.
There was a problem hiding this comment.
I'm not sure. Either @addr4 or @addr6 must have been set in #initialize (otherwise it raises). The compiler can't know about it because that depends on the third-party @family variable. Let's avoid an overload for an impossible case?
spalladino
added
kind:bug
| @@ -107,8 +107,8 @@ class Socket | |||
| def address | |||
There was a problem hiding this comment.
@ysbaddaden @spalladino Please next time prefer adding a return type annotation here, which makes docs more clear and removes the need to write a typeof test for this, which is redundant
There was a problem hiding this comment.
Ok, that's noted!
The socket refactor led
IPAddress#addressto now return a nilable when it should only ever return aString.refs ysbaddaden/prax.cr#42