Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclose true, false and nil in backquote on document comment #3895

Merged

Conversation

makenowjust
Copy link
Contributor

To improve document ;)

Copy link

@mverzilli mverzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thank you very much! ❤️

Would you check the comment I left about 0 literals? Then we'll merge. Thanks!!

# * **strict**: if true, extraneous characters past the end of the number are disallowed
# * **whitespace**: if `true`, leading and trailing whitespaces are allowed
# * **underscore**: if `true`, underscores in numbers are allowed
# * **prefix**: if `true`, the prefixes `"0x"`, `"0"` and `"0b"` override the base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to remove the double quotes so that: 0x, 0 and 0b

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they mean string literal, does not?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right, thanks for clarifying :).

@mverzilli mverzilli merged commit 45e4f22 into crystal-lang:master Jan 14, 2017
@mverzilli mverzilli added this to the Next milestone Jan 14, 2017
@makenowjust
Copy link
Contributor Author

@mverzilli Thanks!

@makenowjust makenowjust deleted the fix/doc/enclose-nil-true-false branch January 14, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants