crystal doc checks is_crystal_repo based on any remote
#3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking only origin
MaxLap
force-pushed
the
max_fix_is_crystal_repo
branch
from
d70b1ba
to
c24a73b
Compare
bcardiff
requested changes
Jan 16, 2017
| @@ -283,6 +283,8 @@ class Crystal::Doc::Generator | |||
|
|
|||
| github_remote_pattern = /github\.com(?:\:|\/)((?:\w|-|_)+)\/((?:\w|-|_|\.)+)/ | |||
| github_remotes = remotes.lines.select &.match(github_remote_pattern) | |||
| @is_crystal_repo = github_remotes.any? { |gr| gr =~ %r{github\.com[/:]crystal-lang/crystal} } | |||
There was a problem hiding this comment.
I think the forward slash should be escaped.
... { |gr| gr =~ %r{github\.com[/:]crystal-lang\/crystal} }
^
There was a problem hiding this comment.
I think that's only needed when using the /..../ syntax, but with %r{...} that's OK
There was a problem hiding this comment.
Not having to espace forward slashes is why I use %r over /.../ in the first place.
bcardiff
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In crystal doc, instead of checking only the origin remote to detect if we are in the crystal repo, check any of the remotes.
I find this useful because I prefer to have my fork as 'origin', and keep the crystal-lang repo as 'lang'. However, doing this means when I
make doc, i don't get the Crystal section with all the builtins.