Removes assert do ... end
#3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luislavena
reviewed
Jan 21, 2017
| return unless Spec.matches?(description, file, line, end_line) | ||
|
|
||
| Spec.formatters.each(&.before_example(description)) | ||
|
|
||
| Spec::RootContext.report(:pending, description, file, line) | ||
| end | ||
|
|
||
| # @deprecated Please use {#it} instead |
There was a problem hiding this comment.
You can use DEPRECATED special markdown tag so the generated code will receive the proper visual handling.
Also use backtick to refer to another method like it.
See the documentation section for more details on the recommended doc style:
https://crystal-lang.org/docs/conventions/documenting_code.html
Cheers.
Sija
reviewed
Jan 22, 2017
| return unless Spec.matches?(description, file, line, end_line) | ||
|
|
||
| Spec.formatters.each(&.before_example(description)) | ||
|
|
||
| Spec::RootContext.report(:pending, description, file, line) | ||
| end | ||
|
|
||
| # DEPRECATED Please use `#it` instead |
There was a problem hiding this comment.
There's colon : missing after the flag name.
|
@TheLonelyGhost Thank you! |
asterite
pushed a commit
that referenced
this pull request
Jan 29, 2017
…xisting code. Related to #3922
Sija
pushed a commit
to Sija/crystal
that referenced
this pull request
Jan 30, 2017
…xisting code. Related to crystal-lang#3922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion on #3921.
it do ... endprovides a drop-in replacement forassert do ... end, ergo it is replaced in all areas where it is used.