Capitalized error messages #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
force-pushed
the
capitalized-error-messages
branch
2 times, most recently
from
a199c95 to
af00b80
Compare
|
Note that capitalizing error message given by the compiler is not correct. Right now with this code: def foo
A = 1
endwe get this error: With your PR we get: which doesn't read that well (capitalizing after ":" doesn't look good). Compiler message are always non-capitalized because of this reason (check for example errors produced by I do agree about capitalizing messages of exceptions thrown in the standard library. |
asterite
requested changes
Jan 30, 2017
Sija
force-pushed
the
capitalized-error-messages
branch
4 times, most recently
from
791699a to
b81021b
Compare
|
@asterite Reverted changes made to compiler as requested. |
Sija
force-pushed
the
capitalized-error-messages
branch
from
b81021b to
ba848dd
Compare
|
@asterite ping? it's ready to 🚢 ! |
Sija
force-pushed
the
capitalized-error-messages
branch
from
ba848dd to
bb38e5d
Compare
Sija
force-pushed
the
capitalized-error-messages
branch
from
bb38e5d to
76de6a9
Compare
|
@asterite anything more to do here? |
asterite
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes error messages according to #3944.