Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve playground specs #4061

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Improve playground specs #4061

merged 1 commit into from
Mar 6, 2017

Conversation

bcardiff
Copy link
Member

Playground: refactor instrumentation to allow specs

  • ensure instrumented code with prelude is able to compile.

@bcardiff
Copy link
Member Author

I needed to change the Header#initialize because it was complaining.
In dd634fd the spec fail
In b7cf798 it is fixed.
I was unable to reduce it any further.

@bcardiff
Copy link
Member Author

I've just narrowed it down. It's another example of #3988 there is something wrong with the order of initializers called in the class lexical scope.

@bcardiff bcardiff added this to the Next milestone Feb 23, 2017
@bcardiff bcardiff changed the title WIP: Improve playground specs Improve playground specs Feb 23, 2017
@bcardiff
Copy link
Member Author

If #3988 is fixed then b185799 can be removed, but improving the specs should be added either way.

ensure instrumented code with prelude is able to compile.
@bcardiff bcardiff merged commit fab030c into master Mar 6, 2017
@bcardiff bcardiff deleted the playground-regression branch March 6, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant