Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec compiler to s c bindings #4103

Merged

Conversation

olbat
Copy link
Contributor

@olbat olbat commented Mar 3, 2017

see discussion in #4098 and #4099

@asterite
Copy link
Member

asterite commented Mar 3, 2017

Thank you! But this seems to also have commits from the other PR. Could you fix that?

(don't worry about travis, it was just in the middle of something broken)

The `to_s` method of C bindings-related AST nodes such as
`lib`, `fun`, `struct`, ... are not tested ATM.
@olbat olbat force-pushed the add_spec_compiler_to_s_c_bindings branch from 6a7b150 to 4f0252e Compare March 4, 2017 10:31
@olbat
Copy link
Contributor Author

olbat commented Mar 4, 2017

Done, thank you for your time !

@asterite asterite merged commit 2500b00 into crystal-lang:master Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants