Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: select generic ARM C bindings when target triple is armv6, armv7l, ... #4167

merged 1 commit into from Mar 23, 2017


Copy link

We don't have specific C bindings for the armv6, armv7l and other specific architectures (e.g. the armhf Debian packages use a armv7l-unknown-linux-gnueabihf triple). We only have bindings for the generic arm target, and this fix tells Crystal to always use these.

Reference: #3424 (comment)

Fixes the target triple used by Crystal to select the LibC bindings
when the triple specifies a specific ARM architecture, e.g. `armv6`,
`armv7l` or `armv8.1-a`.

refs crystal-lang#3424 (comment)
Copy link
Contributor Author

Raspbian (testing) provides LLVM 3.9, so I could reproduce the issue, which should now be fixed for both ARM and AArch64.

Copy link
Contributor Author

Merging. The macOS Sierra failure on CI is unrelated.

@ysbaddaden ysbaddaden merged commit 874eb8b into crystal-lang:master Mar 23, 2017
@ysbaddaden ysbaddaden deleted the fix-arm-target-triple branch March 23, 2017 09:54
@bcardiff bcardiff added this to the 0.22.0 milestone May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants