Merged
Conversation
bcardiff
requested changes
Mar 22, 2017
Member
bcardiff
left a comment
bcardiff
left a comment
There was a problem hiding this comment.
(see comment inline)
In a more general case, this happen for all structs that does not have clone, yet I don't see a problem to allow clone by default on structs. But we can discuss address/discuss that in other PR/issue.
Member
|
@Sija I just realized that my inline comment was never sent. I made a little change. After that we should be able to merge it. |
bcardiff
added
kind:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATM you can't
#cloneanyTupleorNamedTupleincludingTimeinstance.This PR adds
#clonemethod toTime(calls#dupinternally).