WIP/POC: Remove exclusive range syntax #4219
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove_exclusive_range_syntax
…emove_exclusive_range_syntax
bew
reviewed
Apr 1, 2017
Contributor
bew
left a comment
bew
left a comment
There was a problem hiding this comment.
Still some ... Missing, mostly in tests description
|
|
||
| a = [1, 2, 3, 4, 5] | ||
| a[1...1] = 6 | ||
| a[1..0] = 6 |
Contributor
There was a problem hiding this comment.
Are you sure about the 1..0 here?
| (1..0).reverse_each.to_a.empty?.should be_true | ||
| end | ||
|
|
||
| it "is empty with ... and begin > end" do |
Contributor
There was a problem hiding this comment.
You should simply remove the test
| (1..0).reverse_each.to_a.empty?.should be_true | ||
| end | ||
|
|
||
| it "is empty with ... and begin > end" do |
| (1..0).reverse_each.to_a.empty?.should be_true | ||
| end | ||
|
|
||
| it "is empty with ... and begin > end" do |
| (1..0).reverse_each.to_a.empty?.should be_true | ||
| end | ||
|
|
||
| it "is empty with ... and begin > end" do |
| (1..0).reverse_each.to_a.empty?.should be_true | ||
| end | ||
|
|
||
| it "is empty with ... and begin > end" do |
| (1..0).reverse_each.to_a.empty?.should be_true | ||
| end | ||
|
|
||
| it "is empty with ... and begin > end" do |
| (1..0).step(1).to_a.empty?.should be_true | ||
| end | ||
|
|
||
| it "is empty with ... and begin > end" do |
Author
|
Closing to stop spamming the PR queue with this WIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expendable proof of concept for removing exclusive ranges (...) from the language.
Discussed in #4214