Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OpenSSL 1.1.0 changed context options #4234

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

ysbaddaden
Copy link
Contributor

@ysbaddaden ysbaddaden commented Apr 4, 2017

SSLv2 support was removed, some context options were disabled, and the following symbols were previously macros:

  • SSL_CTX_get_options
  • SSL_CTX_set_options
  • SSL_CTX_clear_options

(context.options & OpenSSL::SSL::Options::NO_SSLV3).should eq(OpenSSL::SSL::Options::NO_SSLV3)
(context.options & OpenSSL::SSL::Options::NO_SESSION_RESUMPTION_ON_RENEGOTIATION).should eq(OpenSSL::SSL::Options::NO_SESSION_RESUMPTION_ON_RENEGOTIATION)
(context.options & OpenSSL::SSL::Options::SINGLE_ECDH_USE).should eq(OpenSSL::SSL::Options::SINGLE_ECDH_USE)
(context.options & OpenSSL::SSL::Options::SINGLE_DH_USE).should eq(OpenSSL::SSL::Options::SINGLE_DH_USE)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't assume the options are a fixed set. OpenSSL may have set some by default, already.

SSLv2 support was removed, some context options were disabled, and
the following symbols were previously macros:

- SSL_CTX_get_options
- SSL_CTX_set_options
- SSL_CTX_clear_options
@ysbaddaden ysbaddaden merged commit 3119e59 into crystal-lang:master Apr 4, 2017
@ysbaddaden ysbaddaden deleted the std-fix-openssl-110 branch April 4, 2017 12:38
@bcardiff bcardiff added this to the 0.22.0 milestone May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants