Skip to content

Fix small stuffs#4274

Closed
Sija wants to merge 4 commits intocrystal-lang:masterfrom
Sija:fix-small-stuff
Closed

Fix small stuffs#4274
Sija wants to merge 4 commits intocrystal-lang:masterfrom
Sija:fix-small-stuff

Conversation

@Sija
Copy link
Copy Markdown
Contributor

@Sija Sija commented Apr 11, 2017

This PR introduces couple of small, harmless tweaks/fixes as the title suggests.

@Sija Sija force-pushed the fix-small-stuff branch from 03fd7ca to 4b559c0 Compare April 11, 2017 19:22
@Sija Sija force-pushed the fix-small-stuff branch from 4b559c0 to a2fb5b7 Compare April 11, 2017 19:25
@Sija
Copy link
Copy Markdown
Contributor Author

Sija commented Apr 11, 2017

Damn, I'm still capable of borking a PR, opening next one...

@Sija Sija closed this Apr 11, 2017
@RX14
Copy link
Copy Markdown
Member

RX14 commented Apr 11, 2017

Why not update this PR with force push?

@Sija
Copy link
Copy Markdown
Contributor Author

Sija commented Apr 11, 2017

@RX14 I did. After that, commit 6026ccc unintentionally became part of the PR and I didn't know how to get rid of it.

@Sija Sija deleted the fix-small-stuff branch April 11, 2017 20:22
@RX14
Copy link
Copy Markdown
Member

RX14 commented Apr 11, 2017

You should be able to rebase on master and then force push the results. If all else fails, you can always cherry pick your commits to a new branch and force push that to this PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants