Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add | as a string delimiter #4429

merged 1 commit into from May 20, 2017


Copy link

@RX14 RX14 commented May 18, 2017

Fixes #3467.

I won't be sad if this doesn't get merged but it's a tiny patch and it works through the issue backlog.

Copy link

akzhan commented May 19, 2017

Hello, I just note that Ruby supports any character as delimiter.

See "General Delimited Input" chapter in

Typically '!', '#' are usable too.

Copy link
Contributor Author

RX14 commented May 20, 2017

I can add a few more bit I don't think @asterite wanted to allow every character as a delimiter. Thoughts?

@asterite asterite added this to the Next milestone May 20, 2017
Copy link

I think with just | we are done. I see no reason to support other delimiters. For example Elixir supports the same as Crystal. As always, copying Ruby is not what we should always do. Having more things to write a same concept is worse that having just a few ways (less things to learn). I also never saw something like %*hello* in Ruby, even though it's possible, it will only bring confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants