Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchData: raise KeyError instead of ArgumentError by #[](key: String) #4554



Copy link

Currently #[](key: String) raises ArgumentError. Why? I think it should raise KeyError because it looks like Hash operation.

Currently #[](key: String) raises `ArgumentError`. I think it should
raise `KeyError` because it looks like `Hash` operation.
@asterite asterite added this to the Next milestone Jun 12, 2017
Copy link

Makes sense, thank you!

@asterite asterite merged commit 5fb0438 into crystal-lang:master Jun 12, 2017
@makenowjust makenowjust deleted the fix/regex-match-data/raise-key-error branch August 7, 2017 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants