Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format: fix to format NamedTuple with trailing comma #4697


Copy link

Fixed #4685

For example NamedTuple(foo: Int32,) is formatted to NamedTuple(foo: Int32 (omitted close parenthesis), it is bug and this fix it.

Copy link

RX14 commented Jul 10, 2017

Looks like a weird (unrelated) segfault on 32bit again.

Fixed crystal-lang#4685

For example, `NamedTuple(foo: Int32,)` is formatted to `NamedTuple(foo:
Int32` (omitted close parenthesis), it is bug and this fix it.
@makenowjust makenowjust force-pushed the fix/crystal-format/4685-named-tuple-trailing-comma branch from c947194 to d501a54 Compare July 10, 2017 10:37
@RX14 RX14 merged commit e3763f6 into crystal-lang:master Aug 18, 2017
@RX14 RX14 added this to the Next milestone Aug 18, 2017
@makenowjust makenowjust deleted the fix/crystal-format/4685-named-tuple-trailing-comma branch August 18, 2017 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Crystal format tool generates invalid code/bugs for aliased NamedTuple
3 participants