Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename skip() macro method to skip_file() #4709

Merged
merged 1 commit into from Jul 16, 2017
Merged

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Jul 13, 2017

There was a miscommunication in the macro's name when implementing Crystal::System, meaning that skip_file was used but the method was implemented as skip. In addition, add parens to skip_file to make it parse as a function call.

@akzhan
Copy link
Contributor

@akzhan akzhan commented Jul 13, 2017

LGTM. It follows discussions #4675 (comment) and #4686

There was a miscommunication in the macro's name when implementing
Crystal::System, meaning that skip_file was used but the method was implemented
as skip. In addition, add parens to skip_file to make it parse as a function
call.
@RX14 RX14 force-pushed the feature/rename-skip branch from 7d75cc9 to d1b10e2 Compare Jul 13, 2017
@ysbaddaden ysbaddaden merged commit 9a8586c into master Jul 16, 2017
2 checks passed
@RX14 RX14 added this to the Next milestone Jul 16, 2017
@ysbaddaden ysbaddaden deleted the feature/rename-skip branch Aug 1, 2017
straight-shoota pushed a commit to straight-shoota/crystal that referenced this issue Aug 11, 2017
There was a miscommunication in the macro's name when implementing
Crystal::System, meaning that skip_file was used but the method was implemented
as skip. In addition, add parens to skip_file to make it parse as a function
call.
Val pushed a commit to Val/crystal that referenced this issue Aug 12, 2017
There was a miscommunication in the macro's name when implementing
Crystal::System, meaning that skip_file was used but the method was implemented
as skip. In addition, add parens to skip_file to make it parse as a function
call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants