Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sdl samples work on Linux #4734

Merged
merged 1 commit into from Jul 24, 2017
Merged

Make sdl samples work on Linux #4734

merged 1 commit into from Jul 24, 2017

Conversation

faustinoaq
Copy link
Contributor

@faustinoaq faustinoaq commented Jul 22, 2017

This PR add temporally fix to sdl samples, because these samples don't work currently.

I say temporally because it was discused multiples times before #3678 #381 #388 #387

Also I think if this change make that sdl samples works again on Linux, Ain't better a working sample that a failing sample?

Currently on master:

screenshot_20170721_213857

With this PR:

screenshot_20170721_215050

screenshot_20170721_214247

RX14
RX14 approved these changes Jul 22, 2017
@RX14
Copy link
Contributor

@RX14 RX14 commented Jul 22, 2017

If this doesn't break OSX than I see no reason not to merge it.

@faustinoaq
Copy link
Contributor Author

@faustinoaq faustinoaq commented Jul 22, 2017

@RX14 yes, I kept the OSX part untouched

@ysbaddaden ysbaddaden merged commit cc97885 into crystal-lang:master Jul 24, 2017
2 checks passed
@ysbaddaden
Copy link
Contributor

@ysbaddaden ysbaddaden commented Jul 24, 2017

Allright. I never had a failure, but I don't call SDL_main in the libSDL2 bindings either.

@RX14 RX14 added this to the Next milestone Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants