Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand: show expanded macro name and its location #4773

Conversation

makenowjust
Copy link
Contributor

@makenowjust makenowjust commented Aug 1, 2017

Close #4766

This change will be help to debug a macro.

Example 1:

2017-08-01 21 36 34

Example 2 (nested expansion is supported):

2017-08-01 21 37 12

You can focus the line "# expand macro ...".

@makenowjust makenowjust force-pushed the feature/crystal-expand/show-expanded-macro-name-and-location branch from a46ec1a to d2d148e Compare Aug 1, 2017
@makenowjust
Copy link
Contributor Author

@makenowjust makenowjust commented Aug 2, 2017

Could anyone review this?

@makenowjust
Copy link
Contributor Author

@makenowjust makenowjust commented Aug 14, 2017

Repeat: Could anyone review this? @RX14 @mverzilli @ysbaddaden

@sdogruyol
Copy link
Member

@sdogruyol sdogruyol commented Aug 14, 2017

This is awesome 👍 Thanks @makenowjust

RX14
RX14 approved these changes Aug 15, 2017
@RX14 RX14 merged commit dc877a8 into crystal-lang:master Aug 15, 2017
2 checks passed
@RX14 RX14 added this to the Next milestone Aug 15, 2017
@makenowjust makenowjust deleted the feature/crystal-expand/show-expanded-macro-name-and-location branch Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants