Fix: sanity check /dev/urandom #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
reviewed
Aug 1, 2017
src/crystal/system/unix/getrandom.cr
Outdated
| @@ -12,8 +12,9 @@ module Crystal::System::Random | |||
|
|
|||
| if sys_getrandom(Bytes.new(16)) >= 0 | |||
| @@getrandom_available = true | |||
| else | |||
| elsif File.stat("/dev/urandom").chardev? | |||
There was a problem hiding this comment.
Please use #stat on the opened file descriptor, to avoid race conditions.
There was a problem hiding this comment.
Good catch. Will change.
ysbaddaden
force-pushed
the
fix-add-urandom-chardev-check
branch
from
a609119
to
97d78fc
Compare
Sanity checks /dev/urandom to be character device, not a tempered file, a socket or whatever. Also makes sure that FD_CLOEXEC is set. closes crystal-lang#4752
ysbaddaden
force-pushed
the
fix-add-urandom-chardev-check
branch
from
97d78fc
to
28c8746
Compare
ysbaddaden
changed the title
|
Done. |
jhass
approved these changes
Aug 11, 2017
|
I think this is fine but it would be nice to do something about the duplicated code, especially as it is security related and reflecting any changes in all places is an absolute must. |
|
I'm merging as is. If someone has an epiphany to avoid the duplication in an simple way, please open a pull request :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sanity checks
/dev/urandomto be character device, not a tempered file, a socket or whatever. Also makes sure thatFD_CLOEXECis set.closes #4752