Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OptionParser#order and #order! #4809

Closed

Conversation

DougEverly
Copy link
Contributor

@DougEverly DougEverly commented Aug 8, 2017

Added #order and #order! methods to OptionParser. Intent is to mimic Ruby's #order argument processing such that processing is stops when first unknown arg is reach and remaining is returned as array.

This enables subcommand processes as subcommand can be shifted off array and further processed with subsequent #order calls on the array.

@RX14
Copy link
Contributor

RX14 commented Mar 22, 2018

This PR seems to do a lot of rewriting, i'd rather not have a separate code path for this. Actually it seems like the optionparser needs a rewrite :(

@jhass
Copy link
Member

jhass commented Mar 23, 2018

Personally I never was a big fan of the optionparser interface, so if we decide to rewrite maybe we also should look at other interfaces like slop, thor etc

@straight-shoota
Copy link
Member

straight-shoota commented Dec 6, 2020

Closing. The code is outdated with the refactorings to OptionParser.
The behaviour itself may still be useful but any changes should be proposed in an issue first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants