Document Array#shift? #4886
Merged
Document Array#shift? #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back @porras 👍 |
RX14
requested changes
Aug 26, 2017
src/array.cr
Outdated
| @@ -1507,6 +1507,18 @@ class Array(T) | |||
| ary | |||
| end | |||
|
|
|||
| # Removes the first value of `self`, at index 0. This method returns the removed value. | |||
| # Returns `nil` without raising any error if array is of 0 size. | |||
There was a problem hiding this comment.
I'd turn this sentence around, "If the array is empty..."
There was a problem hiding this comment.
It would make sense, I just copied it from the documentation of the question-mark-less method. Should I change it there too?
There was a problem hiding this comment.
Thanks for the feedback, I just pushed the change.
porras
force-pushed
the
document-array-shift-question-mark
branch
from
e003b2e to
640ddf0
Compare
|
I don't think the build failure is related to the change... |
asterite
approved these changes
Sep 1, 2017
RX14
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.