Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused filename parameter from Formatter #4919

Conversation

miketheman
Copy link
Contributor

@miketheman miketheman commented Sep 3, 2017

The Parser inherits #filename from Lexer, and since Formatter only
needs source, it's not used outside of the Command.

Signed-off-by: Mike Fiedler miketheman@gmail.com

The Parser inherits #filename from Lexer, and since Formatter only
needs `source`, it's not used outside of the Command.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@asterite
Copy link
Member

@asterite asterite commented Sep 5, 2017

But the filename is used in case an exception is raised, for example if there's a parsing error.

@miketheman
Copy link
Contributor Author

@miketheman miketheman commented Sep 12, 2017

@asterite Thanks for explaining! It wasn't apparent fro looking at the code.
Would it be better to have an inline doc to explain this?

@ysbaddaden
Copy link
Contributor

@ysbaddaden ysbaddaden commented Sep 14, 2017

Closing?

@miketheman miketheman closed this Sep 14, 2017
@asterite
Copy link
Member

@asterite asterite commented Sep 14, 2017

@miketheman Most of the compiler is undocumented. I think many things should be documented, but since it's in flux I wouldn't recommend doing it now.

@miketheman miketheman deleted the miketheman/remove-filename-from-formatter branch Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants