Remove unused filename parameter from Formatter#4919
Closed
miketheman wants to merge 1 commit intocrystal-lang:masterfrom
Closed
Remove unused filename parameter from Formatter#4919miketheman wants to merge 1 commit intocrystal-lang:masterfrom
miketheman wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
The Parser inherits #filename from Lexer, and since Formatter only needs `source`, it's not used outside of the Command. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Member
|
But the filename is used in case an exception is raised, for example if there's a parsing error. |
Contributor
Author
|
@asterite Thanks for explaining! It wasn't apparent fro looking at the code. |
Collaborator
|
Closing? |
Member
|
@miketheman Most of the compiler is undocumented. I think many things should be documented, but since it's in flux I wouldn't recommend doing it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Parser inherits #filename from Lexer, and since Formatter only
needs
source, it's not used outside of the Command.Signed-off-by: Mike Fiedler miketheman@gmail.com