Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't find type parameter T of generic type that's not the current type #4974

Merged
merged 2 commits into from Sep 15, 2017
Merged

Don't find type parameter T of generic type that's not the current type #4974

merged 2 commits into from Sep 15, 2017

Conversation

asterite
Copy link
Member

@asterite asterite commented Sep 14, 2017

See comments in the commit for an explanation of the problem and the solution.

Fixes #4460
Fixes #4604

@asterite asterite self-assigned this Sep 14, 2017
@asterite asterite changed the title Don't find T in generic type that's not the current type. Fixes #4460 Don't find type parameter T of generic type that's not the current type. Fixes #4460 Sep 14, 2017
@asterite asterite changed the title Don't find type parameter T of generic type that's not the current type. Fixes #4460 Don't find type parameter T of generic type that's not the current type Sep 14, 2017
@@ -25,6 +25,9 @@ class Crystal::Type
# If *free_vars* is given, when resolving a Path, types will be first searched
# in the given Hash.
#
# If *find_root_generic_type_parameters* is `true` (the default), type parameters
# relative to `self_type` will be found. If `false`, they won't be find.
Copy link
Contributor

@RX14 RX14 Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: find -> found.

RX14
RX14 approved these changes Sep 15, 2017
@RX14
Copy link
Contributor

RX14 commented Sep 15, 2017

I like these two commits, could you squash the typo fix so we can rebase this onto master as 2 commits?

@RX14 RX14 merged commit 3e68043 into crystal-lang:master Sep 15, 2017
@RX14 RX14 added this to the Next milestone Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants