Fix: calling twice proc with extern didn't work #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mverzilli
approved these changes
Sep 16, 2017
mverzilli
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit hard to explain why this fixes it. Some call was setting some property of a Def that later should be reset, but it was done incorrectly so the second time it didn't work.
To be honest, the codegen code related to is super messy and hard to understand, but this fixes it. I'd like to slowly improve the compiler's code (I'd actually like to rewrite it from scratch, but no time), but for now we can only fix things like this.