Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't incorrectly consider local as closured #4986

Merged
merged 1 commit into from
Sep 16, 2017
Merged

Don't incorrectly consider local as closured #4986

merged 1 commit into from
Sep 16, 2017

Conversation

asterite
Copy link
Member

@asterite asterite commented Sep 16, 2017

Fixes #4948

@oprypin
Copy link
Member

oprypin commented Sep 16, 2017

Please don't use "Fix #xxx" as the pull request title, it's extremely hard to keep track of these. More importantly, don't do that to the commit message, it's just not useful to see it in the commit history. There could also be an argument against making hard ties to GitHub -- if it disappears, you have no idea what this was about. If you don't want to spend time writing the commit message, you still have plenty of places to copy it from -- either spec name or issue title.

However, using the "Fix #xxx" in the detailed description of the commit is great.

@asterite asterite changed the title Fix #4948 Don't incorrectly consider local as closured Sep 16, 2017
@asterite
Copy link
Member Author

@oprypin You are right. I was just being lazy 😊

@mverzilli mverzilli added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Sep 16, 2017
@mverzilli mverzilli added this to the Next milestone Sep 16, 2017
@mverzilli mverzilli merged commit 49f9d28 into crystal-lang:master Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants