-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 12hr time formatting #4988
Merged
Merged
Fix 12hr time formatting #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprypin
approved these changes
Sep 16, 2017
Thank you! Would be nice to see how other languages behave here. Also, without specs this is impossible to merge. |
|
Ruby 2.4.1 DateTime.new(2015, 1, 1, 0, 0, 0).strftime("%l %p")
# => "12 AM"
DateTime.new(2015, 1, 1, 12, 0, 0).strftime("%l %p")
# => "12 PM" |
Currently, the time formatting directives `%I` and `%l` return `0` (zero) for midnight/midday, yet in most locales `12` would be preferred. This PR adds a simple ternary check to return `12` when `time.hour % 12` resolves as zero.
@asterite 👍 I've amended my original commit to add specs |
Hmm, is that failure on x86_64 because of something I've done? It passed on i386 |
VM ran out of memory |
asterite
approved these changes
Sep 17, 2017
🕚 to 🚢 |
RX14
added
kind:bug
A bug in the code. Does not apply to documentation, specs, etc.
topic:stdlib
labels
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the time formatting directives
%I
and%l
return0
(zero) for midnight/midday, yet in most locales12
would be preferred. This PR adds a simple ternary check to return12
whentime.hour % 12
resolves as zero.