Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time formatters for days with ordinal suffix. Includes specs and docs. #5057



Copy link

@molovo molovo commented Sep 28, 2017

This PR depends on the methods added in #5054, and so cannot be merged
unless #5054 is merged first.

Two simple, but useful methods. Happy to change the names of the methods
if anyone has better suggestions. Specs included.

This PR depends on the methods added in crystal-lang#5054, and so cannot be merged
unless crystal-lang#5054 is merged first.
Copy link

akzhan commented Sep 28, 2017

Also depends on ICU, should be extracted as shard. I was started crystal-cldr but have no time to finish it yet.

Copy link

asterite commented Oct 14, 2017

This is not common so I'm not sure we should merge this.

Does any other language provide this functionality?

Copy link

akzhan commented Oct 14, 2017

It should be extracted as separate shard anyway. It's related to Unicode CLDR.

@asterite asterite closed this Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants