Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized BitArray.hash(hasher) #5101

Merged
merged 2 commits into from
Oct 14, 2017
Merged

Optimized BitArray.hash(hasher) #5101

merged 2 commits into from
Oct 14, 2017

Conversation

akzhan
Copy link
Contributor

@akzhan akzhan commented Oct 11, 2017

No description provided.

RX14
RX14 requested changes Oct 11, 2017
View reviewed changes
src/bit_array.cr
# See `Object#hash(hasher)`
def hash(hasher)
hasher = size.hash(hasher)
hasher = to_slice.hash(hasher)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should edit the NOTE above in == to mention that hash would have to change too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@akzhan
Copy link
Contributor Author

akzhan commented Oct 11, 2017

Just want to note that CircleCI is someway broken now,

./bin/crystal build  -o .build/std_spec spec/std_spec.cr
ld: library not found for -lgmp

@RX14
Copy link
Contributor

RX14 commented Oct 11, 2017 •
edited
Loading

Yeah, looks like @ilovezfs broke it because of #5089. We should install gmp in the CI script like we do for several other optional dependencies.

@akzhan
Copy link
Contributor Author

akzhan commented Oct 14, 2017

@RX14 looks we need your approve.

@RX14 RX14 added this to the Next milestone Oct 14, 2017
@RX14 RX14 merged commit 1d401e4 into crystal-lang:master Oct 14, 2017
@akzhan akzhan deleted the bit_array.hash branch October 14, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
performance topic:stdlib
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@akzhan @RX14 @asterite