Skip to content

Prevent to type ivar having initializer as nilable on assignment #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RX14 merged 1 commit into from
Oct 15, 2017
Merged

Prevent to type ivar having initializer as nilable on assignment #5120

RX14 merged 1 commit into from
Oct 15, 2017
+19 −1

Conversation

@makenowjust
Copy link
Contributor

@makenowjust makenowjust commented Oct 14, 2017

Fixed #5112

@straight-shoota
Copy link
Member

straight-shoota commented Oct 14, 2017

This should also #4147 I think, but not sure about #1687

asterite
asterite approved these changes Oct 14, 2017
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much!

@RX14 RX14 added this to the Next milestone Oct 15, 2017
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Oct 15, 2017
@RX14 RX14 merged commit 906a8cb into crystal-lang:master Oct 15, 2017
@akzhan
Copy link
Contributor

akzhan commented Oct 15, 2017 •
edited
Loading

@straight-shoota No, #1687 is still broken.

@makenowjust makenowjust deleted the fix/crystal/5112-not-type-ivar-having-initializer-as-nilable branch October 15, 2017 12:37
@Sija Sija mentioned this pull request Nov 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees

No one assigned

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler

Projects

None yet

Milestone

0.24.0

Development

Successfully merging this pull request may close these issues.

5 participants

@makenowjust @straight-shoota @akzhan @asterite @RX14