Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: don't link libs or types inside libs #5152

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Docs: don't link libs or types inside libs #5152

merged 1 commit into from
Oct 20, 2017

Conversation

asterite
Copy link
Member

Fixes #3072

@asterite asterite self-assigned this Oct 20, 2017
@@ -113,6 +113,9 @@ class Crystal::Doc::Generator
return false if nodoc?(type)
return true if crystal_builtin?(type)

# Don't include lib types or types inside a lib type
return false if type.is_a?(Crystal::LibType) || type.namespace.is_a?(LibType)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can there be multiple levels of nesting inside lib types? Does this handle it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, there's only one level of nesting. I thought about that too when writing that line :-)

@RX14 RX14 added this to the Next milestone Oct 20, 2017
@asterite asterite merged commit 74a30e8 into crystal-lang:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants