-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating the example comments to be usable by curl #5263
Conversation
This helps with problems mentioned in issue 5728 crystal-lang#4728
Mh, I really wonder whether we can't bind to all addresses localhost (or any named host) has. |
Isn't this a problem with some local resolvers? |
Binding to The point is that we shouldn't have to change this documentation: it should work. If it doesn't it's a bug and it should be fixed instead of jsut changing the documentation. |
I like localhost better. If someone closes the issue I will close the PR. |
I recall issues on mac where using localhost was not working and 127.0.0.1 was the fix on different products/stacks. Maybe I am used to write whether I want to bind to 0.0.0.0 or to 127.0.0.1 so many times that seems natural to me that an ip is used instead of the localhost word. If the scenario could be improved for localhost, I would say to create a different issue. Having better documentation for the current state is an improvement. |
|
After more searching I think the curl can be fixed but I am not sure if this is the solution. However the browser does not work for me unless I add the protocol and content-length. Something like this.
|
I think more needs to be discussed about this in the issue and what the examples should be showing. |
This helps with problems mentioned in issue 5728
#4728