Tempfile: Add Tempfile.tempname
#5360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new method behaves similarly to the `Dir::Tempname.make_tmpname` method in Ruby in that it creates a filename that is not likely to currently exist on disk. Some key differences: * `tempname` is fully qualified with the value of `Tempfile.dirname`, while `make_tmpname` was not fully qualified by default. * `tempname` does not allow the user to specify a custom prefix. * `tempname` does not allow the user to specify a custom trailing identifier.
woodruffw
force-pushed
the
tempfile-tempname
branch
from
b2044e9 to
069610c
Compare
Contributor
Author
|
For consideration: it looks like Ruby is merging |
Member
|
What exactly is the usecase? |
Contributor
Author
Programs that take a temporary filename to create instead of creating one for themselves. This happens sometimes with programs that open a socket for IPC: they need the user (or invoker) to generate the filename for them, since they don't have a facility for sharing the filename themselves. An example with MPV: tmpfile=$(mktemp -u)
mpv --input-ipc-server="${tmpfile}"
whatever-client-program "${tmpfile}" |
RX14
approved these changes
Dec 7, 2017
asterite
approved these changes
Jan 2, 2018
lukeasrodgers
pushed a commit
to lukeasrodgers/crystal
that referenced
this pull request
Jan 7, 2018
This new method behaves similarly to the `Dir::Tempname.make_tmpname` method in Ruby in that it creates a filename that is not likely to currently exist on disk. Some key differences: * `tempname` is fully qualified with the value of `Tempfile.dirname`, while `make_tmpname` was not fully qualified by default. * `tempname` does not allow the user to specify a custom prefix. * `tempname` does not allow the user to specify a custom trailing identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method behaves similarly to the
Dir::Tempname.make_tmpnamemethod in Ruby in that it creates a filename that is not likely
to currently exist on disk.
Some key differences:
tempnameis fully qualified with the value ofTempfile.dirname,while
make_tmpnamewas not fully qualified by default.tempnamedoes not allow the user to specify a custom prefix.tempnamedoes not allow the user to specify a custom trailingidentifier.
Like
make_tmpnamein Ruby, this implementation is susceptible to TOCTOU, and does not actually test for the file's existence beforehand -- it counts on the space ofRandom.rand(0x100000000).to_s(36)being large enough for most purposes.I'm just learning Crystal, so please let me know if there's anything I can do to improve this PR!