Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Intrinsics.popcount128 #5529

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Use Intrinsics.popcount128 #5529

merged 1 commit into from
Jan 4, 2018

Conversation

sdogruyol
Copy link
Member

According to TODO: use after Crystal 0.23.1 馃憤

@asterite
Copy link
Member

asterite commented Jan 4, 2018

I remember some problems with with Int128 on some platforms, missing librt from llvm. What happened with that?

@sdogruyol
Copy link
Member Author

@asterite is there any issues, comments e.g about the failures so that I can check?

@asterite
Copy link
Member

asterite commented Jan 4, 2018

#5024 (comment)

But maybe it works out of the box in LLVM 5: #5024 (comment)

Probably @RX14 knows more about this.

Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a spec for this (previously it was impossible because Int128 didn't exist)

@RX14
Copy link
Contributor

RX14 commented Jan 4, 2018

Do we have any specs for i128? Aren't they existing but commented out somewhere?

@asterite
Copy link
Member

asterite commented Jan 4, 2018

I don't think so. I didn't write them because I thought we'd drop support for them.

Let's approve this, we can always add specs later, plus Int128 is mostly implemented by LLVM :-P

@RX14 RX14 merged commit aaf7d96 into crystal-lang:master Jan 4, 2018
@RX14 RX14 added this to the Next milestone Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants