Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LLVM update comments #5530

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

sdogruyol
Copy link
Member

SSIA 馃憤

@asterite
Copy link
Member

asterite commented Jan 4, 2018

I don't know who wrote those llvm intrinsics, but they don't seem to exist. Plus I don't see what's the point of Math.div(x, y) when x / y does the same thing (and seems to be implemented the same way).

I think we should remove these instead.

@RX14
Copy link
Contributor

RX14 commented Jan 4, 2018

To make them compile, I suspect you need to add the .f32 etc suffix to match the other bindings below. Not sure what their use is either, looking at them more carefully.

@asterite
Copy link
Member

asterite commented Jan 4, 2018

I'm 99% sure they don't exist. At least they are not listed in the reference.

@RX14
Copy link
Contributor

RX14 commented Jan 4, 2018

Interesting, I wonder how these ended up here then.

@sdogruyol
Copy link
Member Author

@asterite removed 馃憤

@asterite asterite added this to the Next milestone Jan 5, 2018
@asterite asterite merged commit 2b60437 into crystal-lang:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants