Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround llvm.powi.* intrinsics not available on win32 #5538

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Jan 4, 2018

No description provided.

@RX14 RX14 added this to the Next milestone Jan 4, 2018
@luislavena
Copy link
Contributor

@RX14 wouldn't be better move the platform condition down to LibM and define those func replacements there instead?

Apologies if this was discussed elsewhere.

Thank you.

@RX14
Copy link
Contributor Author

RX14 commented Jan 4, 2018

@luislavena I'm not sure what you mean...

@luislavena
Copy link
Contributor

Apologies for the brevity of previous message.

I was thinking something similar to the approach taken in #5533 and reduce the number of places platform condition needs to be checked to only LibM.

Cheers.

@RX14
Copy link
Contributor Author

RX14 commented Jan 4, 2018

@luislavena no, I did that because creating an entirely new function is the only way to create a new va_list.

@luislavena
Copy link
Contributor

Thanks for the clarification. Was simply a thought.

Cheers.

@RX14 RX14 merged commit f8b35d1 into crystal-lang:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants