Compiler: emit .o file to a temporary location and then atomically rename it#5585
Merged
asterite merged 1 commit intocrystal-lang:masterfrom Jan 15, 2018
asterite:refactor/improved-cache
Merged
Compiler: emit .o file to a temporary location and then atomically rename it#5585asterite merged 1 commit intocrystal-lang:masterfrom asterite:refactor/improved-cache
.o file to a temporary location and then atomically rename it#5585asterite merged 1 commit intocrystal-lang:masterfrom
asterite:refactor/improved-cache
Conversation
RX14
approved these changes
Jan 14, 2018
|
I ran into an issue where I used |
Member
|
@monouser7dig very likely. |
|
So I could probably try that (if brew --HEAD build works at the moment) or maybe this helps you to reproduce. entr was a fantastic mention from your size btw. thanks, very useful |
luislavena
approved these changes
Jan 15, 2018
Contributor
luislavena
left a comment
luislavena
left a comment
There was a problem hiding this comment.
I did encounter this a few times. Was unable to replicate after a clean cache and a few break attempts around debugging symbols, but the change to bring atomic creation of object files is welcome 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was suggested by @RX14
Sometimes we get an error on a compilation that happens after we interrupted a previous compilation. It can happen that a
.ofile was being generated but it was interrupted, leaving a corrupted file that was later (incorrectly) reused.This PR changes that so that the object file is first generated with a
.o.tmpname, and then moved to the final location withFile.rename, which should be an atomic operation.I tried to reproduce the cache problem but couldn't (it's hard). We can try this fix and see if it happens again. Or if someone knows how to reproduce the problem, they might try to see if this PR fixes it for them.