New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dup and clone for JSON::Any and YAML::Any #6266

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
5 participants
@asterite
Contributor

asterite commented Jun 25, 2018

Fixes #6220

Please don't ask me code examples on these ones, they are trivially understood.

@ysbaddaden

❤️

@jhass

jhass approved these changes Jun 26, 2018

@@ -2,6 +2,8 @@ module Crystal::Doc::Highlighter
extend self

def highlight(code)
compiler = Compiler.new

This comment has been minimized.

@jhass

jhass Jun 26, 2018

Member

Huh?

This comment has been minimized.

@asterite

asterite Jun 26, 2018

Contributor

I thought it was a good idea... but yeah, let's remove this.

@asterite asterite force-pushed the asterite:feature/6220-json-any-dup branch from cf58748 to 657a084 Jun 26, 2018

@bcardiff bcardiff added this to the 0.25.1 milestone Jun 26, 2018

@bcardiff bcardiff merged commit 0004179 into crystal-lang:master Jun 26, 2018

4 checks passed

ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asterite asterite deleted the asterite:feature/6220-json-any-dup branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment