New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: silence errors from system_spec on BSD platforms #6289

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
None yet
4 participants
@jcs
Contributor

jcs commented Jun 28, 2018

On platforms where getconf _NPROCESSORS_ONLN doesn't work, like OpenBSD, each command emits an error:

Before:

$ crystal spec spec/std/system_spec.cr 
/usr/local/lib/libevent_core.so.1.1: warning: random() may return deterministic values, is that what you want?
.getconf: _NPROCESSORS_ONLN: unknown variable
-: nproc: not found
grep: /proc/cpuinfo: No such file or directory
.

Finished in 16.14 milliseconds
2 examples, 0 failures, 0 errors, 0 pending

After:

$ crystal spec spec/std/system_spec.cr
/usr/local/lib/libevent_core.so.1.1: warning: random() may return deterministic values, is that what you want?
..

Finished in 16.03 milliseconds
2 examples, 0 failures, 0 errors, 0 pending
@jhass

jhass approved these changes Jun 28, 2018

@RX14

RX14 approved these changes Jun 29, 2018

@RX14 RX14 merged commit bfd9e6d into crystal-lang:master Jun 29, 2018

3 of 4 checks passed

ci/circleci: test_darwin Your tests failed on CircleCI
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RX14 RX14 added this to the Next milestone Jun 29, 2018

@RX14 RX14 modified the milestones: Next, 0.26.0 Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment